Resolve
Ask reviewImplement permanent fix with proper testing and review
Dependencies
Hat Sequence
Engineer
Focus: Implement the permanent fix that addresses the root cause, not just the symptom. Write regression tests that would catch this failure mode. The mitigation bought time — now use it to do the job properly.
Produces: Code fix with regression tests, deployment plan, and documentation of how the fix differs from the temporary mitigation.
Reads: Root cause from investigation, mitigation log, relevant codebase and infrastructure configuration.
Anti-patterns (RFC 2119):
- The agent MUST NOT ship the mitigation as the permanent fix without addressing the root cause
- The agent MUST NOT write a fix without a regression test that would have caught this incident
- The agent MUST consider whether the same class of bug exists elsewhere in the codebase
- The agent MUST NOT skip the deployment plan because "it's just a small change"
- The agent MUST NOT leave the temporary mitigation in place without a plan to remove it
Reviewer
Focus: Review the permanent fix for correctness, completeness, and safety. Verify it addresses the root cause, not just the trigger. Ensure regression tests are meaningful and the deployment plan is sound.
Produces: Review assessment covering code correctness, test adequacy, deployment risk, and whether the fix fully addresses the root cause.
Reads: Engineer's fix, root cause from investigation, mitigation log, regression tests.
Anti-patterns (RFC 2119):
- The agent MUST NOT rubber-stamp because the incident is resolved and urgency has passed
- The agent MUST NOT review only the diff without understanding the root cause it's meant to fix
- The agent MUST verify the regression test actually fails without the fix applied
- The agent MUST NOT ignore deployment risk because the mitigation is already in place
- The agent MUST check whether the temporary mitigation cleanup is included or planned
Review Agents
Correctness
Mandate: The agent MUST verify the permanent fix addresses the root cause with adequate testing.
Check:
- The agent MUST verify that fix addresses the root cause identified in the investigation, not just the symptom
- The agent MUST verify that test coverage includes the specific failure scenario that caused the incident
- The agent MUST verify that regression tests prevent this class of failure, not just this exact instance
- The agent MUST verify that fix does not reintroduce the conditions that led to the incident
Resolve
Criteria Guidance
Good criteria examples:
- "Fix addresses the root cause identified in investigation, not just the symptom the mitigation covered"
- "Test coverage includes a regression test that would have caught this incident before it reached production"
- "Deployment plan includes canary or staged rollout with rollback criteria"
Bad criteria examples:
- "Code is fixed"
- "Tests pass"
- "Deployed to production"
Completion Signal (RFC 2119)
Permanent fix is implemented and addresses the root cause, not just the symptom. Regression tests exist that would catch this specific failure mode. Code review MUST be complete. Deployment plan specifies rollout strategy and monitoring criteria. Resolution summary documents the fix, how it differs from the mitigation, and confirms the mitigation can be safely removed.